Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-128

pyside-tools build error (trivial change)

    XMLWordPrintable

Details

    • Bug
    • Resolution: Invalid
    • Not Evaluated
    • 1.2.x
    • 1.2.x
    • PySide
    • None
    • OS X 10.6, 10.7, 10.8

    Description

      The version of pyside allowed in pyside-tools/CMakeLists.txt is too low
      and contradicts the submodules table in setup.py.
      As an effect, 'setup/py build' may find an older pyside-1.1.0 that was
      installed elswhere, and the build crashes when trying to build pyside-tools.

      The patch changes the minimum version pyside-tools/CMakeLists.txt
      to 1.1.1 as in setup.py .

      diff --git a/CMakeLists.txt b/CMakeLists.txt
      index 1d609d7..9fa3169 100644
      — a/CMakeLists.txt
      +++ b/CMakeLists.txt
      @@ -3,8 +3,8 @@ cmake_minimum_required(VERSION 2.6)
      project(pyside-tools)

      find_package(PythonInterp REQUIRED)
      -find_package(Qt4 4.5.0 REQUIRED)
      -find_package(PySide 1.0.6 REQUIRED)
      +find_package(Qt4 4.6.0 REQUIRED)
      +find_package(PySide 1.1.1 REQUIRED)

      set(pyside_tools_MAJOR_VERSION "0")
      set(pyside_tools_MINOR_VERSION "2")

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            Unassigned Unassigned
            ctismer Christian Tismer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes