Uploaded image for project: 'Qbs ("Cubes")'
  1. Qbs ("Cubes")
  2. QBS-542

[WiX] Wrong handling of the "-culture" property

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P3: Somewhat important
    • 1.2.0
    • 1.2.0, some future version
    • General
    • None
    • * QtCreator v3.1 beta
      * Windows 8x64
    • 944ac35a55af62a1a372aa873470e3d6c73143f3

    Description

      The linker rule do wrongly handling for the "cultures" property.

      Instead of:

      if (product.type.contains("msi")) {
          var cultures = ModUtils.moduleProperty(product, "cultures");
          args.push("-cultures:" + (cultures ? cultures.join(";") : "null"));
      }
      

      should be added "cultures.isEmpty" function:

      if (product.type.contains("msi")) {
          var cultures = ModUtils.moduleProperty(product, "cultures");
          args.push("-cultures:" + (cultures.isEmpty ? cultures.join(";") : "null"));
      }
      

      then to the linker will be passed correctly: "-culture:null" value.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            kuzulis Denis Shienkov
            kuzulis Denis Shienkov
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes