Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-18625

lrelease -markuntranslated does not work for non-id-based TS files

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P3: Somewhat important
    • 4.7.4
    • 4.6.2, 4.7.2
    • Tools: Linguist
    • None
    • 688d6db785af821e76b9e436ef9d9cbea95ef5ad

    Description

      When trying lrelease -markuntranslated <prefix> it did not work; all untranslated texts were removed. After having a look at the source code it's obvious that -markuntranslated currently only works in combination with -idbased. I do not see a reason for this restriction. The following change makes -markuntranslated also work for non-idbased TS files.

      --- tools/linguist/shared/qm.cpp
      +++ tools/linguist/shared/qm.cpp
      @@ -723,7 +723,7 @@
                       continue;
                   }
                   if (typ == TranslatorMessage::Unfinished) {
      -                if (!cd.m_idBased && msg.translation().isEmpty()) {
      +                if (!cd.m_idBased && cd.m_unTrPrefix.isEmpty() && msg.translation().isEmpty()) {
                           ++untranslated;
                           continue;
                       } else {
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            buddenha Oswald Buddenhagen
            ingokloecker Ingo Klöcker
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes