Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-25485

Consider using QRegularExpression instead of QRegExp in testlib implementation

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • P3: Somewhat important
    • 5.13.0
    • None
    • Testing: qtestlib
    • None
    • ffc71a977f4bef2872c5c93ddd4db7ebaee8e356

    Description

      Quoting Thiago in https://codereview.qt-project.org/#change,24080

      QRegExp matching methods modify the object, which we don't want to. In
particular, when we receive a QRegExp from the user or we store in a
context that might require thread-safety, make sure we make a copy
before using it.

QRegularExpression has no such shortcoming.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            sgaist Samuel Gaist
            jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes