Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-31343

GCC -Wpacked warning in qlocale.h when using Qt 4.8.4 headers

    XMLWordPrintable

Details

    • Bug
    • Resolution: Invalid
    • P5: Not important
    • None
    • 4.8.4
    • Core: QString and Unicode
    • None
    • Linux x86 32-bit

    Description

      An x86 project that uses Qt 4.8.4 headers will get a compiler warning if the GCC flag -Wpacked is activated (http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html).

      I believe that the underlying issue is a typo in http://qt.gitorious.org/qt/qt/commit/c9424fa6687b5d83227c8c07df1e3806b8f487b5

      The patch of qlocale.h uses || instead of &&. Since QT_NO_ARM_EABI is defined for all platforms, not only ARM (see line 519 of qglobal.h), Q_PACKED gets set for all platforms.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            liaqi Liang Qi
            mmartalo@cisco.com Mihai Martalogu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes