Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-7469

4.6.1 qfsfileengine.cpp uses Q_OS_LINIX instead of Q_OS_LINUX

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Not Evaluated
    • 4.6.2
    • 4.6.1
    • Core: I/O
    • None
    • 2a988be53a60156cc5210b251e7a9904426c823c

    Description

      Between 4.6.0 & 4.6.1, a change was made to qfsfileengine.cpp to "Improve performance of getting the canonical filename on Linux and Symbian by using realpath() system call." (from changes-4.6.1). However, the if defined() check is wrong. On line 147, it's attempting to detect Linux & Symbian. However it checks against Q_OS_LINIX instead of Q_OS_LINUX, thus nullifying the performance improvement.

      To fix, change

      #if defined(Q_OS_LINIX) || defined(Q_OS_SYMBIAN)
      ...

      to

      #if defined (Q_OS_LINUX) || defined(Q_OS_SYMBIAN)

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            mgoetz Markus Goetz (Inactive)
            dbroady1 Darin Broady
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes