Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-9870

Avoidable compiler warning with missing case for IconID unknownID in uic generated header file in method qt_get_icon

    XMLWordPrintable

Details

    • Bug
    • Resolution: Invalid
    • P4: Low
    • 4.7.1
    • 4.6.0
    • Tools: Designer
    • None
    • Windows XP, Visual Studio 2005

    Description

      For all uic files containing icons the generated header files contains and iconID enumerator, with a last one called "unknown_ID".
      The "unknown_ID" enum value is not part of the switch-case statement selecting the icons, this leads to a warning that the value is not used in the switch.
      Please generate fallthrough in switch in method "static QPixmap qt_get_icon(IconID id)" like this:
      case unknown_ID:
      default: return QPixMap

      Attachments

        1. qt9870_example.tgz
          4 kB
        2. qt9870.patch
          2 kB
        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            kleint Friedemann Kleint
            j.kreuzberger Joerg Kreuzberger
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes