Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-3411

Fix up the editor manager API (internal+external)

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P2: Important
    • None
    • None
    • All Other Issues
    • None

    Description

      Many of the methods in there have funny side effects. Others are inconsistent. Other API is public and looks like it shouldn't, or at least fixed up then.
      To name a few things

      • openEditorWithContents doesn't activate the editor, and doesn't take OpenEditorFlags
      • openEditorsModel is exported + activateEditor(index, flags)
      • activateEditor(view, editor, OpenEditorFlag::NoActivate) doesn't make sense, but is actually used (for the placeEditor call, which is a side effect)
      • activateEditor(IEditor *) doesn't have any sensible semantic, since IEditors are not necessarily associated to a view (after split/unsplit)

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            con Eike Ziller
            con Eike Ziller
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes