XMLWordPrintable

Details

    • Suggestion
    • Resolution: Out of scope
    • Not Evaluated
    • None
    • None
    • Gerrit
    • None

    Description

      Early warning system is one of the most helpful tool when working in a big open source community as Qt does. It not only helps improving quality of a code and set a common understanding of coding policies but also helps new people in community to quickly check if their patches are correct and pass minimal requirements to be approved. Currently, each patch to be staged, needs two positives scores one is a "code review" which is given by humans and the second one is "sanit review" mostly given by Qt Sanity bot. This approach works but is not flexible enough. We want to have more bots, doing boring automatic checks, but current solution doesn't allow us to have a multiple, independent sanity reviews, because bots would over-vote them selfs. Moreover we can not be sure how reliable new bots would be, so we can not block staging just because of a one bot. On the other hand using "code review" category for automatic checks reduce ability to search for un-reviewed patches, and it looks weird...

      I would like to propose a third review category; "automatic review", that would be used by external bots to give a feedback about a patch, without reducing ability to stage. Purely informational. Currently we have Qt Doc bot that would use that category. I know that another bot, that checks license, is under construction. I would expect more of them in future. I think two possible scores would make sens in this case -1 and +1, but may be also -2 to +2, it doesn't matter as it should not influence anything. The only point of it is to help a reviewer to spot bogus parts of a contribution.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            buddenha Oswald Buddenhagen
            nierob Nierob
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes