Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-11475 QtScript's patches to JavaScriptCore
  3. QTBUG-11716

[QtScript/JavaScriptCore] Fix tst_QScriptEngine::throwErrorFromProcessEvents

    XMLWordPrintable

Details

    • Sub-task
    • Resolution: Done
    • P2: Important
    • None
    • Qt Script
    • None

    Description

      Patch: http://gitorious.org/+qtwebkit-developers/qtwebkit/qtwebkit-qtscript-integration/commit/d2e46389ae7aee02b76ab3d4f65bfb5cc57f4cf2

      The issue here is that JSC doesn't expect didTimeOut() to throw an exception – but since we made it virtual, that can happen (since we call out to application code. which can do anything).

      "while(true){}" is not a realistic script to be running. We could say that throwing an error due to processEvents() will not cause the script to abort in this case. But if arbitrary scripts can be provided by the user, this could be exploited...

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              kenthans Kent Hansen (Inactive)
              kenthans Kent Hansen (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes