Details
-
Bug
-
Resolution: Done
-
P1: Critical
-
4.7.2
-
None
-
Arch Linux on x86_64 computer using Qt and KDE packages compiled from latest trunk.
-
22995948cd3f46780be5d8016708aeef0cd7b066
Description
The patch in Qt-bug 231 which replaced linear search with a binary search seems to have introduced an off-by-one error into the code in two places. This bug manifests itself as a crash in koffice when compiled against Qt from trunk if you hit the "tab" key on a new line in the text shape.
I have added a comment to that bug report and attached a patch which I will also attach here.
I have also created a bug report on bugs.kde.org (bug #265369) and linked it to this bug report.
Attachments
For Gerrit Dashboard: QTBUG-17209 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
2343,1 | Fix off-by-one error in binary search | master | qt/qtbase | Status: MERGED | +2 | 0 |
34115,2 | Optimize QTextEngine::findItem by using a binary search. | 4.8 | qt/qt | Status: MERGED | +2 | 0 |