Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-21862

Bugs in our copy of clucene library

    XMLWordPrintable

Details

    • Bug
    • Resolution: Out of scope
    • P4: Low
    • 5.9
    • 5.0.0
    • Tools: Assistant
    • None

    Description

      Found from static code analysis:

      V547 Expression '-- size >= 0' is always true. Unsigned type value is always >= 0. QtCLucene arrays.h 154

          bool equals( class1* val1, class2* val2 ) const{
          {
            ...
            size_t size = val1->size();
            ...
            while ( --size >= 0 ){
              if ( !comp(*itr1,*itr2) )
                return false;
              itr1++;
              itr2++;
            }
            ...
          }
      

      ----------------------------------------------------------

      V547 Expression 'q->getQueryName () != L"BooleanQuery"' is always true. To compare strings you should use wcscmp() function. QtCLucene multifieldqueryparser.cpp 44

        Query* MultiFieldQueryParser::parse(...)
        {
          ...
          if (q && (q->getQueryName() != _T("BooleanQuery")
          ...
        }
      

      And here:

      V547 Expression 'q->getQueryName () != L"BooleanQuery"' is always true. To compare strings you should use wcscmp() function. QtCLucene multifieldqueryparser.cpp 63

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            heimrich Karsten Heimrich
            kenthans Kent Hansen (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes