Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-22432

Syncqt does not always generate fwd-include headers when namespaces are used

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • 5.1.0
    • 5.0.0
    • Build tools: qmake
    • None
    • Reproduced with latest qt5 + qtpim master branches on desktop linux (ubuntu 10.10).
    • 0114a99bad161fb0e8de5a384e7e13c9a79f8c98

    Description

      For add-on modules using their own namespaces, the camel-case public header files are not generated if the class is declared right after the namespace start.
      For example, in http://qt.gitorious.org/qt/qtpim/blobs/master/src/contacts/details/qcontactname.h (with master = f022a06f7cb218df4a10b04da8a98c0f56cd60f2), the QContactName header file is not generated by syncqt.
      But, if I modify the header file, for example as:

      diff --git a/src/contacts/details/qcontactname.h b/src/contacts/details/qcontact
      index ad2a7c2..5aea9aa 100644
      --- a/src/contacts/details/qcontactname.h
      +++ b/src/contacts/details/qcontactname.h
      @@ -50,7 +50,7 @@
       #include <qcontactfilter.h>
       
       QTCONTACTS_BEGIN_NAMESPACE
      -
      +/**/
       class Q_CONTACTS_EXPORT QContactName : public QContactDetail
       {
       public:
      

      then the QContactName header file is generated.
      I suspect there might be a problem in the parsing logic of syncqt, that originally did not really include support for namespaces, and might still need some fixes in order to be really usable in the qt5 scope (where add on modules will require often a working support for namespaces).

      Attachments

        1. 0001-Allow-syncqt-to-ignore-module-specific-macros.patch
          1 kB
          Lincoln Ramsay (closed Nokia identity)
        2. 0001-Tell-syncqt-to-ignore-macros.patch
          0.8 kB
          Lincoln Ramsay (closed Nokia identity)
        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            buddenha Oswald Buddenhagen
            cristiano cristiano di flora
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes