Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-24673

4.8.0 QtScript JavaScriptCore causes compilation error for GCC 4.7.0

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P3: Somewhat important
    • 4.8.2, 5.0.0
    • 4.8.0
    • Qt Script
    • None
    • 80451ee3

    Description

      Compilation of 4.8.0 with GCC 4.7.0 breaks due to errors in

      • src/3rdparty/javascriptcore/JavaScriptCore/runtime/JSStaticScopeObject.h
      • src/3rdparty/javascriptcore/JavaScriptCore/runtime/JSGlobalObject.h

      Proposed fixes:

      • src/3rdparty/javascriptcore/JavaScriptCore/runtime/JSStaticScopeObject.h
        
        

        + class JSGlobalObject : public JSVariableObject {
        + protected:
        +- using JSVariableObject::JSVariableObjectData;
        +-
        +- struct JSGlobalObjectData : public JSVariableObjectData {
        ++ struct JSGlobalObjectData : public JSVariableObject::JSVariableObjectData

        { + // We use an explicit destructor function pointer instead of a + // virtual destructor because we want to avoid adding a vtable + // pointer to this struct. Adding a vtable pointer would force the {cocde}

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            kenthans Kent Hansen (Inactive)
            lgeyer Lukas Geyer
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes