Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-29334

QWSKeyboardHandler implementation for INTEGRITY does not work

    XMLWordPrintable

Details

    Description

      The class QWSIntKbPrivate in src/gui/embedded/qkbdintegrity_qws.h/.cpp seems to be completely untested and hence does not work.

      Here is a patch to fix the issue (this patch does not fix the FIXME comment!):

      diff -rup qt-everywhere-commercial-src-4.8.4/src/gui/embedded/qkbdintegrity_qws.cpp qt-everywhere-commercial-src-4.8.4-patched/src/gui/embedded/qkbdintegrity_qws.cpp
      — qt-everywhere-commercial-src-4.8.4/src/gui/embedded/qkbdintegrity_qws.cpp 2012-11-23 11:28:53.000000000 +0100
      +++ qt-everywhere-commercial-src-4.8.4-patched/src/gui/embedded/qkbdintegrity_qws.cpp 2013-01-24 17:06:09.000000000 +0100
      @@ -108,13 +108,13 @@ class QWSIntKbPrivate : public QObject
      public:
      QWSIntKbPrivate(QWSKeyboardHandler *, const QString &device);
      ~QWSIntKbPrivate();

      • void dataReady(uint32_t keycode, bool pressed) { emit kbdDataAvailable(keycode, pressed); }
        + void dataReady(quint32 keycode, bool pressed) { emit kbdDataAvailable(keycode, pressed); }

      Q_SIGNALS:

      • void kbdDataAvailable(uint32_t keycode, bool pressed);
        + void kbdDataAvailable(quint32 keycode, bool pressed);

      private Q_SLOTS:

      • void readKeyboardData(uint32_t keycode, bool pressed);
        + void readKeyboardData(quint32 keycode, bool pressed);

      private:
      QWSKeyboardHandler *handler;
      @@ -256,17 +256,18 @@ void QIntKeyboardListenThread::run(void)
      QThread::exit(0);
      }

      -void QWSIntKbPrivate::readKeyboardData(uint32_t keycode, bool pressed)
      +void QWSIntKbPrivate::readKeyboardData(quint32 keycode, bool pressed)

      { handler->processKeycode(keycode, pressed, false); }

      QWSIntKbPrivate::QWSIntKbPrivate(QWSKeyboardHandler *h, const QString &device) : handler(h)

      { - connect(this, SIGNAL(kbdDataAvailable(uint32_t, bool)), this, SLOT(readKeyboardData(uint32_t, bool))); + connect(this, SIGNAL(kbdDataAvailable(quint32, bool)), this, SLOT(readKeyboardData(quint32, bool))); this->handler = handler; qDebug("Opening INTEGRITY keyboard"); kbdthread = new QIntKeyboardListenThread(this); + kbdthread->setup(QString(), 0); kbdthread->start(); }

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            Unassigned Unassigned
            flobe Florian Behrens
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes