Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-38061

Includes linux-only headers breaking freebsd

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • 5.3.0 RC1
    • 5.2.1
    • Multimedia
    • Debian sid
    • d3ba2d6f3f7cbdd8a4e41a7967874f53a2caaec3

    Description

      The following files include linux-only headers:

      src/plugins/v4l/radio/v4lradiocontrol.h:51:#include <linux/types.h>
      src/plugins/gstreamer/camerabin/camerabincontrol.cpp:53:#include <linux/types.h>
      src/plugins/gstreamer/camerabin/camerabinserviceplugin.cpp:53:#include <linux/types.h>
      src/plugins/gstreamer/audiodecoder/qgstreameraudiodecoderserviceplugin.cpp:52:#include <linux/types.h>
      src/plugins/gstreamer/mediaplayer/qgstreamerplayerserviceplugin.cpp:54:#include <linux/types.h>
      src/plugins/gstreamer/mediacapture/qgstreamercaptureserviceplugin.cpp:54:#include <linux/types.h>
      src/plugins/gstreamer/mediacapture/qgstreamerv4l2input.cpp:47:#include <linux/types.h>
      src/gsttools/qgstreamervideoinputdevicecontrol.cpp:47:#include <linux/types.h>

      freebsd simply changes linux/types.h with sys/types.h as can be seen in:

      <http://svnweb.freebsd.org/ports/head/multimedia/qt5-multimedia/Makefile?revision=346930&view=markup>

      In Debian's kfreebsd port I will start doing so, but it would be great if this situation could be handled directly in upstream

      Thanks!

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            ylopes Yoann Lopes
            lisandropm Lisandro Damián Nicanor Pérez Meyer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes