Details
-
Bug
-
Resolution: Done
-
Not Evaluated
-
5.3.0 Beta1
-
None
-
All
-
5f0fbc683bce200b17fea82eb711d8ad4c2f3f23 480cbb2b00b80baa90676fb3adfa982711006da8
Description
webkitwidgets\browser:
- Lots of #ifdefs Q_WS_QWS (dead) and Q_WS_MAC (use: Q_OS_OSX or QGuiApplication::platformName() == "cocoa")
- Semi-fishy arguments parsing using QCoreApplication::arguments (should use QCommandLineParser, see fex https://codereview.qt-project.org/#change,81954 )
- Apparently implements some local-server server , could use QLockFile?
- Bookmarks should contain qt.digia.com from start (see fex https://codereview.qt-project.org/#change,79074 )
webkitwidgets\fancybrowser (what is so fancy about this example, btw?)
- Leaks mainwindow
- fishy arguments parsing using argv, should use QCommandLineParser)
- Default URL is Google, should be qt-project.org
Long/mid-term we will have several browser engines , it seems (WebKit, WebEngine, Active X IE and other native engines). It would probably help having some shared code or example for a browser that can use any of them...
Attachments
For Gerrit Dashboard: QTBUG-38069 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
82876,6 | Fix up Fancy Browser example. | stable | qt/qtwebkit-examples | Status: ABANDONED | +2 | 0 |
82882,7 | Fix up tabbed browser example. | stable | qt/qtwebkit-examples | Status: ABANDONED | +2 | 0 |
83379,1 | Fix up Fancy Browser example. | release | qt/qtwebkit-examples | Status: MERGED | +2 | 0 |
83380,1 | Fix up tabbed browser example. | release | qt/qtwebkit-examples | Status: MERGED | +2 | 0 |