Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-2187

Qt Creator help plugin is broken - incorrectly depends to QtWebKit now even if it is not available

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • Qt Creator 2.1.0
    • None
    • Help System
    • None
    • Latest Qt Creator master branch.
      commit c8bb37d275b14abe54973bad0526e2123aec0d34
      Author: Bill King <bill.king@nokia.com>
      Date: Thu Aug 26 09:24:15 2010 +1000
    • 8c070031df143b2e28195c0833d012d4995a7ff5

    Description

      Qt Creator master branch: help plugin lost conditional dependency to QtWebKit now
      It was not so about 1 week ago.

      There are a lot of
      #if !defined(QT_NO_WEBKIT)
      in src/plugins/help/helpplugin.cpp, but some changes are added without such checks.

      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp: In member function 'void Help::Internal::HelpPlugin::slotAboutToShowBackMenu()':
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1065: error: 'QWebHistory' was not declared in this scope
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1065: error: 'history' was not declared in this scope
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1065: error: 'class Help::Internal::HelpViewer' has no member named 'history'
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1067: error: 'QWebHistoryItem' was not declared in this scope
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1067: error: template argument 1 is invalid
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1067: error: invalid type in declaration before '=' token
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1068: error: request for member 'count' in 'items', which is of non-class type 'int'
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1070: error: request for member 'at' in 'items', which is of non-class type 'int'
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp: In member function 'void Help::Internal::HelpPlugin::slotAboutToShowNextMenu()':
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1080: error: 'QWebHistory' was not declared in this scope
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1080: error: 'history' was not declared in this scope
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1080: error: 'class Help::Internal::HelpViewer' has no member named 'history'
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1082: error: 'QWebHistoryItem' was not declared in this scope
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1082: error: template argument 1 is invalid
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1082: error: invalid type in declaration before '=' token
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1083: error: request for member 'count' in 'items', which is of non-class type 'int'
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1086: error: request for member 'at' in 'items', which is of non-class type 'int'
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp: In member function 'void Help::Internal::HelpPlugin::slotOpenActionUrl(QAction*)':
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1096: error: 'QWebHistory' was not declared in this scope
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1096: error: 'history' was not declared in this scope
      /home/mdn/src/qt/qt-creator/src/plugins/help/helpplugin.cpp:1096: error: 'class Help::Internal::HelpViewer' has no member named 'history'

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            heimrich Karsten Heimrich
            mdn Denis Mingulov
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes