check these Krazy reports

krazy2 Analysis

Checkers Run = 33
Files Processed = 33
Total Issues = 141 ...as of August 26 2011 12:02:12 CEST

4. Check for cpp macros and usage [cpp]... 6 issues found
qsystem.cpp: O/S or Compiler specific macro line#56[Q_OS_WIN32],92[Q_OS_WIN32],139[Q_OS_WIN32,Q_OS_WIN64],165[Q_OS_AIX],195[Q_OS_WIN32],204[Q_OS_WIN32] (6)
(might not be applicable)

5. Check for code that should be considered crashy. [crashy]... 4 issues found
qttestplugin.cpp: line#294 (1)
testexecuter.cpp: line#1291 (1)
testselector.cpp: line#867,1476 (2)

6. Check single-char QString operations for efficiency [doublequote_chars]... 58 issues found
dialogs.cpp: line#100,133 (2)
dialogs.cpp: split issues line#93 (1)
qsystem.cpp: line#295,312,489,496,506,508,536 (7)
qsystem.cpp: starts/endsWith issues line#407 (1)
qsystem.cpp: split issues line#196,198 (2)
resultsview.cpp: line#276,289 (2)
resultsview.cpp: starts/endsWith issues line#284 (1)
testcode.cpp: starts/endsWith issues line#1178 (1)
testcode.cpp: split issues line#310 (1)
testconfigurations.cpp: line#806,811 (2)
testconfigurations.cpp: starts/endsWith issues line#781 (1)
testconfigurations.cpp: split issues line#623,639,748,779,802 (5)
testcontextmenu.cpp: line#249 (1)
testexecuter.cpp: line#460,582,599,629,632,635,639,654,680,682,686,791,903,905,913,1049 (16)
testexecuter.cpp: starts/endsWith issues line#532,546 (2)
testexecuter.cpp: split issues line#544,587,1029 (3)
testselector.cpp: line#224,234,860,874 (4)
testselector.cpp: split issues line#858 (1)
testsettings.cpp: starts/endsWith issues line#86,180 (2)
testsettings.cpp: split issues line#179 (1)
testsettingspropertiespage.cpp: line#252,258 (2)

9. Check for QString compares to "" [emptystrcompare]... 7 issues found
qsystem.cpp: line#96 (1)
resultsview.cpp: line#286 (1)
testexecuter.cpp: line#783 (1)
testgenerator.cpp: line#153 (1)
testresultuploader.cpp: line#112 (1)
testselector.cpp: line#1193 (1)
testsettings.cpp: line#86 (1)

11. Check for C++ ctors that should be declared 'explicit' [explicit]... 3 issues found
dialogs.h: line#68 (1)
resultsview.h: line#53 (1)
testselector.h: line#115 (1)

12. Check for foreach loop issues [foreach]... 2 issues found
testcode.cpp: non-const ref iterator line#587 (1)
testconfigurations.cpp: non-const ref iterator line#780 (1)

15. Check for proper include directives [includes]... 1 issue found
qttestplugin.cpp: duplicate includes line#42,46(coreplugin/coreconstants.h)

18. Check for assignments to QString::null [nullstrassign]... 1 issue found
testexecuter.cpp: line#200 (1)

29. Check for spelling errors [spelling]... 1 issue found
qsystem.cpp: line#421[occurance] (1)

30. Check for improperly initialized global static objects [staticobjects]... 7 issues found
resultsview.cpp: line#70,71,72 (3)
testselector.cpp: line#357,358,359,360 (4)

31. Check for strings used improperly or should be i18n. [strings]... 33 issues found
qsystem.cpp: QLatin1String issues line#271,277,407,538 (4)
resultsview.cpp: QLatin1String issues line#216,219,221,223,225,229,284 (7)
testcode.cpp: QLatin1String issues line#266,281,283,285,287,351,896,1120,1178,1268 (10)
testconfigurations.cpp: QLatin1String issues line#781 (1)
testcontextmenu.cpp: QLatin1String issues line#314,315,316 (3)
testexecuter.cpp: QLatin1String issues line#532,546,608,677,710,717,725 (7)
testsettings.cpp: QLatin1String issues line#180 (1)