Uploaded image for project: 'Qt Installer Framework'
  1. Qt Installer Framework
  2. QTIFW-295

AutoDependOn with script argument only is not working

    XMLWordPrintable

Details

    • Bug
    • Resolution: Invalid
    • P2: Important
    • None
    • 1.3.0, 1.4.0
    • General
    • None

    Description

      QStringList Component::autoDependencies() const
      {
          QStringList autoDependencyStringList =
              d->m_vars.value(scAutoDependOn).split(QInstaller::commaRegExp(), QString::SkipEmptyParts);
          autoDependencyStringList.removeAll(QLatin1String("script"));
          return autoDependencyStringList;
      }
      
      bool Component::isAutoDependOn(const QSet<QString> &componentsToInstall) const
      {
          // If there is no auto depend on value or the value is empty, we have nothing todo. The component does
          // not need to be installed as an auto dependency.
          QStringList autoDependOnList = autoDependencies();
          if (autoDependOnList.isEmpty())
              return false;
      

      ^^^ ups it returns false even there is script inside the value -> wrong

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            installerteam Installer Team
            tjenssen Tim Jenssen
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes