Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-238

Keep +2 reviews valid even if new patch set is pushed

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Done
    • P3: Somewhat important
    • None
    • None
    • Gerrit
    • None

    Description

      You often have reviews like 'patch is okay, but maybe fix the typo in the commit message?'. That is, I'd like to give the general commit an okay, but the original author might consider to fix a few small things. I trust the committer enough to decide for himself though to do these, and don't want to be bothered to do yet another review.

      Gerrit right now requires a final review for the very last patch-set committed. It could also keep a +2 as a valid review for the whole patch, even if a new patch-set is added afterwards.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            gerrit-admin Gerrit Admin
            kkohne Kai Köhne
            Votes:
            6 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes