Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-464

should refuse to stage/submit when other reviews came in meanwhile

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Unresolved
    • P2: Important
    • None
    • 2011q3
    • Gerrit
    • None

    Description

      it is somewhat common that while somebody has a review open, somebody else does a review at the same time. the other reviewer may give a -1, but the current reviewer may still give +2 and immediately stage the change without ever noticing the other reviewer's objections.

      in such cases gerrit should display some kind of "in-flight collision" message like bugzilla does.
      i think a straight-forward solution would be posting the comment and review score, but refusing to stage/submit if any other comments were added meanwhile.
      clicking the submit button on the review page itself should obviously trigger the same error.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              gerrit-admin Gerrit Admin
              buddenha Oswald Buddenhagen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes