Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-856

keyboard navigation in diff-all view botched

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • None
    • 2014q2
    • Gerrit
    • None
    • 958f2a44a03e215d78667c28296b0c22b3df9d07

    Description

      the j/k/c/etc. keyboard navigation doesn't play well with mouse navigation: if you click into a file (other than the commit message, obviously), and then use the navigation keys, they'll still operate inside the commit message. when you use w/q to navigate between files, it works.

      on a related note, the need to use w/q (rather than j/k simply moving across files) in the diff-all screen is entirely counterproductive.
      also, it makes no sense at all that hitting r in the combined screen jumps to the normal review screen instead of to the cover message edit which already is on the page.

      Attachments

        Issue Links

          For Gerrit Dashboard: QTQAINFRA-856
          # Subject Branch Project Status CR V

          Activity

            People

              ishaataj Ismo Haataja
              buddenha Oswald Buddenhagen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes